[effects/blur] Check for blitting support
ClosedPublic
Actions

Authored by anemeth on May 31 2018, 7:03 PM.

Details

Reviewers

Group Reviewers

Commits

Summary

In D12678 blur was changed to use blitFromFramebuffer() instead of glCopyTexSubImage2D()
Now it checks if the GPU supports it.

Repository

R108 KWin

Branch

check_for_blit_support (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Restricted Application added a project: KWin. · View Herald TranscriptMay 31 2018, 7:03 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

anemeth requested review of this revision.May 31 2018, 7:03 PM

anemeth retitled this revision from Check for blitting support to [effects/blur] Check for blitting support.May 31 2018, 7:09 PM

This revision is now accepted and ready to land.Jun 1 2018, 9:39 AM

This revision was automatically updated to reflect the committed changes.

I'm a little bit too late, but...

effects/blur/blur.cpp
336	IMHO, length of this line is too big now. const bool supported = effects->isOpenGLCompositing && GLRenderTarget::supported() && GLRenderTarget::blitSupported(); would be better.

effects/blur/blur.cpp
336	You make a good point, but there are lines already longer than this in `blur.cpp` Anyways you could create a revision that splits long lines into multiple ones. The value of `supported` might be changed below so it can't be `const` (although scrolling through the file I counted multiple occurrences where `const` could be added, maybe another revision?)

			Path	Packages
M			effects/blur/blur.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	35277	b3b691a		May 31 2018, 7:03 PM	★	★
Diff 2	35312	b3b691a	R108:81f38abe6d6db94f56c0d2e857fd90cc1a73c293	Jun 1 2018, 10:18 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
af97215bd3cc	c4d6798a5c66	b3b691a25074	Alex Nemeth	Check for blitting support	May 31 2018, 7:02 PM