Differential D13223

Set kcm context property on the correct context
ClosedPublic
Actions

Authored by davidedmundson on May 30 2018, 8:55 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R296:c49f51c19854: Revert "GHNS button"
R296:5ec7d0d83d0f: Set kcm context property on the correct context
Summary

One code path of kdeclarative uses a shared engine.

If we have a shared engine we have one engine with a root context and
several sub contexts. In this case it's important to set properties on
the context of our QQmlObject, not the shared root context of the
engine.

Test Plan

I didn't see it affecting anything as one tends to only open one KCM at a time

Loaded the fonts KCM in system settings
Loaded the volume KCM via the plasma-pa applet

Diff Detail

Repository
R296 KDeclarative
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.May 30 2018, 8:55 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 30 2018, 8:55 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.May 30 2018, 8:55 PM
hein accepted this revision.May 30 2018, 8:57 PM
This revision is now accepted and ready to land.May 30 2018, 8:57 PM
Closed by commit R296:5ec7d0d83d0f: Set kcm context property on the correct context (authored by davidedmundson). · Explain WhyJun 1 2018, 9:38 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/quickaddons/configmodule.cpp (2 lines)

Diff 35307

View Options

src/quickaddons/configmodule.cpp

Loading...