Differential D13176

kpackage_install_*package: fix missing dep between .desktop and .json
ClosedPublic
Actions

Authored by kossebau on May 28 2018, 5:04 PM.

Details

Reviewers
bshah
Group Reviewers
Plasma
Commits
R290:58968e8a9914: kpackage_install_*package: fix missing dep between .desktop and .json
Summary

dd_custom_command needs to be told when to rerun by explicitly listing the
dependecies, e.g. by passing used input files by the DEPENDS argument.

Test Plan

Touching kdeplasma-addons applets/activitypager/metadata.desktop file now
properly results in a regeneration of the json variant.

Diff Detail

Repository
R290 KPackage
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.May 28 2018, 5:04 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 28 2018, 5:04 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.May 28 2018, 5:04 PM
hein added a subscriber: hein.May 28 2018, 5:22 PM

The patch works on my corrupted build dir that prompted its creation. I'm not qualified to accept CMake changes though.

bshah accepted this revision.May 28 2018, 5:23 PM
This revision is now accepted and ready to land.May 28 2018, 5:23 PM
kossebau updated this revision to Diff 35042.May 28 2018, 5:34 PM

avoid repeating calculation of metadata path

Closed by commit R290:58968e8a9914: kpackage_install_*package: fix missing dep between .desktop and .json (authored by kossebau). · Explain WhyMay 28 2018, 5:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MKF5PackageMacros.cmake (12 lines)

Diff 35043

View Options

KF5PackageMacros.cmake

Loading...