Add ellipsis to actions that open up a dialog. It doesn't seem to work for Twitter, probably because it's different to the other plugins.
Details
Diff Detail
- Repository
- R495 Purpose Library
- Branch
- ellipsis
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 9403 Build 9421: arc lint + arc unit
That's not correct. This is the plugin name. If you want elipsis add it onto the model's displayrole.
It's done this way in Email, KTP and KDE Connect already. If we add the ellipsis in AlternativesModel's DisplayRole we get it on every entry, even if it would be inappropriate.
Quote from VDG:
If there will be further user input needed and a dialogue or similar popping up for it: needs ellipsis
Therefore Pastebin would not need one, but I guess this is neglectable
This results in every item in the menu getting an ellipsis, which isn't appropriate because not all of them require more user action to proceed (the imgur plugin is one such example). It seems like we need a way to indicate in the desktop file that the plugin will require user interaction and need an ellipsis displayed in the UI, without hardcoding that information with an ellipsis in the plugin's own name.
This sounds like a hack as well. I think we need another translatable field in JSON, independent from "Name".
Here is a similar problem with KIO: https://bugs.kde.org/show_bug.cgi?id=243287
We probably need to fall back to "%1..." if X-Purpose-Action is not defined, which is possible for 3rd-party plugins.