Differential D13068

Filter out incognito tabs and media controls on Firefox
ClosedPublic
Actions

Authored by broulik on May 23 2018, 3:56 PM.

Details

Reviewers
fvogt
davidedmundson
Group Reviewers
Plasma
Commits
R856:8ddc5bc6f920: Filter out incognito tabs and media controls on Firefox
Summary

Chrome doesn't run extensions in incognito mode by default whereas Firefox does.
Filter out incognito tabs from Browser Tabs Runner as well as disable media controls for those sites to prevent accidental private information leak.

Test Plan
  • Favicons still work for normal tabs in runner
  • Incognito tabs weren't found anymore in runner
  • Incognito tabs are still found when extension is explicitly whitelisted in Chrome
  • Media controls still worked for normal pages
  • Media controls were not offered for incognito pages

Didn't touch kde connect as that is something you explicitly have to do on the actual page and same for downloads I guess

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.May 23 2018, 3:56 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 23 2018, 3:56 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.May 23 2018, 3:56 PM
davidedmundson accepted this revision.May 23 2018, 3:58 PM
This revision is now accepted and ready to land.May 23 2018, 3:58 PM
Closed by commit R856:8ddc5bc6f920: Filter out incognito tabs and media controls on Firefox (authored by broulik). · Explain WhyMay 24 2018, 7:42 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mextension/extension.js (26 lines)

Diff 34776

View Options

extension/extension.js

Loading...