AppletConfiguration: Respect button visibility preference of KCModules
ClosedPublic

Authored by drosca on Apr 2 2016, 3:10 PM.

Details

Summary

Don't show Apply button when it's not in KCModule::buttons().

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
drosca updated this revision to Diff 3078.Apr 2 2016, 3:10 PM
drosca retitled this revision from to AppletConfiguration: Respect button visibility preference of KCModules.
drosca updated this object.
drosca edited the test plan for this revision. (Show Details)
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptApr 2 2016, 3:10 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sebas added a subscriber: sebas.Apr 3 2016, 12:23 PM
sebas added inline comments.
desktoppackage/contents/configuration/AppletConfiguration.qml
345

Isn't there an enum defined for this? The hardcoded int is really ugly and prone to fail.

broulik added a subscriber: broulik.Apr 3 2016, 1:38 PM
broulik added inline comments.
desktoppackage/contents/configuration/AppletConfiguration.qml
345

I don't think there's an easy way to expose the enum in kcmodule.h to QML easily :/

drosca added inline comments.Apr 6 2016, 8:57 AM
desktoppackage/contents/configuration/AppletConfiguration.qml
345

The enum value is defined in KDeclarative::ConfigModule and is only accessible from the QML KCM itself.

sebas accepted this revision.Apr 6 2016, 10:28 AM
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.Apr 6 2016, 10:28 AM
This revision was automatically updated to reflect the committed changes.