Differential D12931

Make target_link_libraries for kdeinit_dolphin PRIVATE
ClosedPublic
Actions

Authored by almiller on May 16 2018, 3:44 PM.

Details

Reviewers
elvisangelaccio
Group Reviewers
Dolphin
Commits
R318:8e6f4eecd318: Make target_link_libraries for kdeinit_dolphin PRIVATE
Summary

There is no need to add all of kdeinit_dolphin's
dependencies (including the static archive) when
linking dolphin; kdemain is the only needed symbol.
Mark the link libraries PRIVATE to simplify the
link command for dolphin.

Diff Detail

Repository
R318 Dolphin
Lint
Lint Skipped
Unit
Unit Tests Skipped
almiller created this revision.May 16 2018, 3:44 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptMay 16 2018, 3:44 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
almiller requested review of this revision.May 16 2018, 3:44 PM
This revision is now accepted and ready to land.May 16 2018, 9:19 PM
Closed by commit R318:8e6f4eecd318: Make target_link_libraries for kdeinit_dolphin PRIVATE (authored by almiller, committed by asturmlechner). · Explain WhyMay 18 2018, 10:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/CMakeLists.txt (2 lines)

Diff 34302

View Options

src/CMakeLists.txt

Loading...