Improve two messages
ClosedPublic

Authored by gregormi on May 15 2018, 10:27 PM.

Details

Reviewers
aacid
Group Reviewers
KDE Games
Commits
R417:b6e059b12644: Improve two messages
Summary

BUG: 357999
CCBUG: 242300

  1. Improve Low Difficulty warning message to solve Bug 357999 ("Missing word in Low Difficulty warning message")
  2. Improve Bug 242300 ('"Generate A Puzzle" hangs when big games like 16x16 or 25x25 games are chosen"): Warns users that generation of Unlimited mode puzzles takes long time
  3. Explain better what "Enable all messages" means

Diff Detail

Repository
R417 KSudoku
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gregormi created this revision.May 15 2018, 10:27 PM
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptMay 15 2018, 10:27 PM
Restricted Application added a subscriber: kde-games-devel. · View Herald Transcript
gregormi requested review of this revision.May 15 2018, 10:27 PM
gregormi updated this revision to Diff 34240.May 15 2018, 10:39 PM
  • change spaces back to tabs
gregormi updated this revision to Diff 34249.May 16 2018, 12:43 AM
  • Bug 357999: improve "Low Difficulty" warning
gregormi edited the summary of this revision. (Show Details)May 16 2018, 12:44 AM

The english, at least in the last one (enable all messages) seems a bit weird, but not being a native speaker i can't really suggest a better alternative. @ngraham do you have some time to review the text changes in here?

I am getting the same vibe not sure off hand how to improve it. One
instance is missing connector word. The wording is understandable but
awkward. I am not in position to offer official review in any case.

Sorry, I don't feel like I'm familiar enough with the app in question to be able to offer a lot of assistance here, especially for the first change. The second one seems fine to me. The third one seems really awkward. Do we even need a confirmation dialog to confirm this in the first place?

gregormi edited the summary of this revision. (Show Details)May 30 2018, 9:27 AM

To summarize the current reviewers responses,

  • "Improve Low Difficulty warning message to solve Bug 357999"
    • OK (or not familiar with game)
  • "Improve Bug 242300: Warns users that generation of Unlimited mode puzzles takes long time"
    • OK
  • "Explain better what "Enable all messages" means"
    • QUESTIONABLE. For me, in the current state, I cannot deduce what the action is supposed to do because the menu item text only says "Enable all messages" . The confirmation dialog can serve as a vehicle to explain what the action does.
aacid added a comment.Jun 4 2018, 10:35 PM

For message 3 this is my suggestion, what do you think?

This will enable all the dialogs that you had disabled by marking the 'Do not show this message again' option.\n\nDo you want to enable them?

last question may be just "Do you want to continue?"

gregormi updated this revision to Diff 36916.Jun 29 2018, 9:45 PM
  • rebase on master
  • improve "enable all messages" message
  • improve "difficulty warning" message

@aacid I used your suggestion to fix the message. It sounds more natural and fluent. From my side this is now ready to land.

aacid accepted this revision.Jul 2 2018, 9:32 PM
This revision is now accepted and ready to land.Jul 2 2018, 9:32 PM
This revision was automatically updated to reflect the committed changes.