Much code in the white and black keys were repeated.
A new file PianoKey.qml has been created and the common code is generalized and put into it.
Details
Details
- Reviewers
jjazeix - Group Reviewers
GCompris: Improvements - Maniphest Tasks
- T8690: Add feedback animation on pressing piano keys.
Diff Detail
Diff Detail
- Repository
- R2 GCompris
- Lint
Lint Skipped - Unit
Unit Tests Skipped
src/activities/piano_composition/PianoKey.qml | ||
---|---|---|
8 | oops, I missed writing (Qt Quick port) here. If the diff is fine, I'll mention it before committing. |
src/activities/piano_composition/PianoKey.qml | ||
---|---|---|
23 | 2.6 |
Comment Actions
Pushed to gsoc_aman_piano_activities with the required changes.
Commit link: https://cgit.kde.org/gcompris.git/commit/?h=gsoc_aman_piano_activities&id=10a179fd3638a0cad864e6a7cb7f4880da6ffa07