Differential D12866

piano_composition, reafactor white and black keys into one.
ClosedPublic
Actions

Authored by amankumargupta on May 14 2018, 9:08 AM.

Details

Reviewers
jjazeix
Group Reviewers
GCompris: Improvements
Maniphest Tasks
T8690: Add feedback animation on pressing piano keys.
Summary

Much code in the white and black keys were repeated.
A new file PianoKey.qml has been created and the common code is generalized and put into it.

Diff Detail

Repository
R2 GCompris
Lint
Lint Skipped
Unit
Unit Tests Skipped
amankumargupta created this revision.May 14 2018, 9:08 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptMay 14 2018, 9:08 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
amankumargupta requested review of this revision.May 14 2018, 9:08 AM
amankumargupta added inline comments.May 14 2018, 9:56 AM
src/activities/piano_composition/PianoKey.qml
8

oops, I missed writing (Qt Quick port) here. If the diff is fine, I'll mention it before committing.

jjazeix accepted this revision.May 14 2018, 10:10 AM
jjazeix added a subscriber: jjazeix.
jjazeix added inline comments.
src/activities/piano_composition/PianoKey.qml
23

2.6

This revision is now accepted and ready to land.May 14 2018, 10:10 AM

Revision Contents
Changeset List

Diff 34117

View Options

src/activities/piano_composition/Piano.qml

Loading...
View Options

src/activities/piano_composition/PianoKey.qml

Loading...