Differential D12759

Fix saving and opening of SQL storage
AbandonedPublic
Actions

Authored by wojnilowicz on May 8 2018, 2:49 PM.

Details

Reviewers
tbaumgart
Group Reviewers
KMyMoney
Summary

This fixes database handling (SQLite) for following scenarios:

  1. opening database manually and then trying to save it,
  2. opening database from recent files list and then trying to save it.

Both scenarios failed for me, so I fixed them.

Diff Detail

Repository
R261 KMyMoney
Lint
Lint Skipped
Unit
Unit Tests Skipped
wojnilowicz requested review of this revision.May 8 2018, 2:49 PM
wojnilowicz created this revision.
christiand added a subscriber: christiand.May 12 2018, 11:41 AM

I am not into this code, so I can only give general advice.

kmymoney/kmymoney.cpp
973

From my point of view the auto reduces readability without adding a benefit.

981

Here, too.

996

nbak should be a self-describing name.

wojnilowicz added a comment.May 12 2018, 12:10 PM
In D12759#261339, @christiand wrote:

I am not into this code, so I can only give general advice.

I agree. Code is not elegant and not very tidy here but that's what makes things work. Anyhow, I would like to change code for opening files further, so it's not bad for me for now.

kmymoney/kmymoney.cpp
973

I don't think it's really what counts in a review thing. I like to use auto and use it whenever I can. That's like not worth discussing.

996

I agree but that's not the code that I'm changing :)

tbaumgart added a comment.May 12 2018, 1:04 PM

Compiles for me. Seems to work also. No further checking done.

wojnilowicz abandoned this revision.May 14 2018, 2:04 PM

Revision Contents
Changeset List

Diff 33829

View Options

kmymoney/kmymoney.cpp

Loading...
View Options

kmymoney/plugins/sql/sqlstorage.cpp

Loading...