Differential D12717

add style fallback
ClosedPublic
Actions

Authored by astippich on May 6 2018, 11:57 AM.

Details

Reviewers
mgallien
Group Reviewers
Elisa
Commits
R255:937c8aabf4f2: add style fallback
Summary

always fall back to fusion style

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich requested review of this revision.May 6 2018, 11:57 AM
astippich created this revision.
mgallien requested changes to this revision.May 6 2018, 5:31 PM
mgallien added a subscriber: mgallien.

Could you ad screenshots ?

src/windows/qtquickcontrols2.conf
6–7 ↗(On Diff #33704)

In my opinion, it should be the opposite given that the Universal style is not so good looking on desktops especially Windows 7.

This revision now requires changes to proceed.May 6 2018, 5:31 PM
astippich updated this revision to Diff 33803.May 8 2018, 5:58 AM
  • remove windows specific styles
astippich added a comment.May 8 2018, 6:00 AM
In D12717#258804, @mgallien wrote:

Could you ad screenshots ?

No, sorry, I currently don't have a Windows setup. I just saw T8598 and thought fixing should be easy. Anything should be better than the default style. I now altered the patch to provide a fallback theme everywhere.

mgallien accepted this revision.May 8 2018, 7:29 AM

Please update the commit message and land your patch.

This revision is now accepted and ready to land.May 8 2018, 7:29 AM
astippich retitled this revision from add style fallback and adjust for windows to add style fallback.May 9 2018, 6:22 PM
astippich edited the summary of this revision. (Show Details)
Closed by commit R255:937c8aabf4f2: add style fallback (authored by astippich). · Explain WhyMay 9 2018, 6:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/qtquickcontrols2.conf (1 line)

Diff 33901

View Options

src/qtquickcontrols2.conf

Loading...