Differential D12651

Preserve QUrl
ClosedPublic
Actions

Authored by rizzitello on May 2 2018, 1:01 AM.

Details

Reviewers
tcanabrava
patrickelectric
laysrodrigues
Commits
R231:d36e9fb9352b: Preserve QUrl
R231:4b75a7f3dd9f: Preserve QUrl
Summary

File Chooser returns QUrls now this fixes not printing if a file was selected from the dialog.

Diff Detail

Repository
R231 Atelier
Branch
fixmultiprint
Lint
No Linters Available
Unit
No Unit Test Coverage
rizzitello requested review of this revision.May 2 2018, 1:01 AM
rizzitello created this revision.
tcanabrava added inline comments.May 2 2018, 9:14 AM
src/dialogs/choosefiledialog.h
31

return by copy, not by reference.

rizzitello marked an inline comment as done.May 2 2018, 8:27 PM
rizzitello updated this revision to Diff 33519.May 2 2018, 8:29 PM
rizzitello edited the summary of this revision. (Show Details)
  • rebase / tomaz suggestion
patrickelectric accepted this revision.May 2 2018, 8:54 PM
This revision is now accepted and ready to land.May 2 2018, 8:54 PM
laysrodrigues accepted this revision.May 3 2018, 1:24 AM
rizzitello closed this revision.May 3 2018, 1:38 AM

Revision Contents
Changeset List

Diff 33536

View Options

src/dialogs/choosefiledialog.h

Loading...
View Options

src/dialogs/choosefiledialog.cpp

Loading...