IMAP Resource: handle disconnection before initial "OK" from server
ClosedPublic

Authored by dfaure on Apr 21 2018, 5:49 PM.

Details

Summary

1b79b4b in kimap makes connectionLost useful again, as the best way
to detect that we managed to connect (so the server actually exists and is
(or was) reachable) and then lost connection. Use that instead of the state change
to distinguish from the wrong hostname case (where we don't want to retry, we'd loop
forever doing that).

Test Plan

Expand existing unittest to test 3 different cases of connection lost,
all after the initial connect. The next method (shouldNotifyFailureToConnect)
ensures that the "wrong hostname" case still works.

Diff Detail

Repository
R44 KDE PIM Runtime
Branch
Applications/18.04
Lint
No Linters Available
Unit
No Unit Test Coverage
dfaure created this revision.Apr 21 2018, 5:49 PM
Restricted Application added a project: KDE PIM. ยท View Herald TranscriptApr 21 2018, 5:49 PM
dfaure requested review of this revision.Apr 21 2018, 5:49 PM
dvratil accepted this revision.Apr 21 2018, 7:54 PM
This revision is now accepted and ready to land.Apr 21 2018, 7:54 PM
dfaure closed this revision.Apr 21 2018, 7:58 PM