Differential D12254

[effects/minimizeanimation] Don't reset timeline
ClosedPublic
Actions

Authored by zzag on Apr 16 2018, 5:16 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:3fcce012c02f: [effects/minimizeanimation] Don't reset timeline
Summary

Resetting timeline while animating a window causes some visual "glitches",
see videos below. Even though we can't use QTimer::toggleDirection,
that's safe to delete code which resets timeline because prePaintScreen
figures out correct direction of the timeline.

Before

After

Diff Detail

Repository
R108 KWin
Branch
minimize-dont-reset-timeline
Lint
No Linters Available
Unit
No Unit Test Coverage
zzag created this revision.Apr 16 2018, 5:16 PM
Restricted Application added a project: KWin. · View Herald TranscriptApr 16 2018, 5:16 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Apr 16 2018, 5:16 PM
zzag edited the summary of this revision. (Show Details)Apr 16 2018, 5:56 PM
davidedmundson accepted this revision.Apr 19 2018, 9:50 PM
This revision is now accepted and ready to land.Apr 19 2018, 9:50 PM
Closed by commit R108:3fcce012c02f: [effects/minimizeanimation] Don't reset timeline (authored by zzag). · Explain WhyApr 20 2018, 6:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 32309

View Options

effects/minimizeanimation/minimizeanimation.cpp

Loading...