Diffusion KWin c44788889c50

[platforms/virtual] Make VirtualOutput non-copyable

Authored by zzag on Apr 14 2018, 8:45 PM.

Description

[platforms/virtual] Make VirtualOutput non-copyable

Summary:
Qt objects are treated as identities so remove the copy constructor and
an assignment operator. See, http://doc.qt.io/qt-5/object.html#identity-vs-value

IIRC some Qt objects(like QImage) have copy constructor for implicit data sharing,
but VirtualOutput doesn't have anything to share.

Also, it [this patch] fixes a compiler warning:

/home/vlad/KDE/src/kde/workspace/kwin/plugins/platforms/virtual/virtual_output.cpp: In copy constructor ‘KWin::VirtualOutput::VirtualOutput(const KWin::VirtualOutput&)’:
/home/vlad/KDE/src/kde/workspace/kwin/plugins/platforms/virtual/virtual_output.cpp:30:1: warning: base class ‘class QObject’ should be explicitly initialized in the copy constructor [-Wextra]
 VirtualOutput::VirtualOutput(const VirtualOutput &o)
 ^~~~~~~~~~~~~

Reviewers: KWin, romangg

Reviewed By: KWin, romangg

Subscribers: michaelh, kwin

Tags: KWin

Differential Revision: https://phabricator.kde.org/D12214

Details

Committed
zzagApr 15 2018, 11:48 PM
Reviewer
KWin
Differential Revision
D12214: [platforms/virtual] Make VirtualOutput non-copyable
Parents
R108:d3f8b979a0c2: Fix warning
Branches
Unknown
Tags
Unknown