Differential D12245

algorithm activity, block clicks while bonus is running.
ClosedPublic
Actions

Authored by amankumargupta on Apr 16 2018, 1:05 PM.

Details

Reviewers
timotheegiet
Group Reviewers
GCompris: Improvements
Maniphest Tasks
T8537: Logical association (algorithm), block clicks on fruits while bonus is running.
Summary
  1. Clicks on the fruits are blocked when bonus is running.
  1. Increased the size of question tray a bit to prevent a minute part of some fruits go out of it when scaled.

Diff Detail

Repository
R2 GCompris
Lint
Lint Skipped
Unit
Unit Tests Skipped
amankumargupta created this revision.Apr 16 2018, 1:05 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptApr 16 2018, 1:05 PM
Restricted Application added a subscriber: KDE Edu. · View Herald Transcript
jjazeix added a subscriber: jjazeix.Apr 16 2018, 3:34 PM
jjazeix added inline comments.
src/activities/algorithm/Algorithm.qml
70 ↗(On Diff #32275)

would using Keys.enabled be better?

amankumargupta updated this revision to Diff 32298.Apr 16 2018, 3:42 PM

used Keys.enabled to block keyboard presses.

amankumargupta marked an inline comment as done.Apr 16 2018, 3:42 PM
timotheegiet accepted this revision.Apr 17 2018, 11:19 AM
timotheegiet added a subscriber: timotheegiet.

Tested, and changes looks good. Thanks for the little cleaning.
Please commit.

This revision is now accepted and ready to land.Apr 17 2018, 11:19 AM

Revision Contents
Changeset List

Diff 32298

View Options

src/activities/algorithm/Algorithm.qml

Loading...
View Options

src/activities/algorithm/algorithm.js

Loading...