Convert to the new connect syntax.
Details
- Reviewers
dfaure - Group Reviewers
Frameworks - Commits
- R241:ee0a0f1ef323: kdirlister new connect syntax
Compiles and the tests pass.
Diff Detail
- Repository
- R241 KIO
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Signals having changed from protected to public in Qt5, the whole idea of preventing others to emit signals went down the drain anyway. Extending that to KJob we could make the signals non-private there, with strong documentation "don't emit this yourself".
I have renamed one private slot because I didn't find a better solution.
QOverload seems to work only for signals, not for slots.
Change the first connect.
No need to change the name of the slot.
Pass the plain error message.
Looks good, but shouldn't you remove the Q_PRIVATE_SLOT declarations too? They aren't used anymore, AFAICS.
src/core/kcoredirlister.cpp | ||
---|---|---|
2720 | missing space after the first comma |
I meant this stuff:
src/core/kcoredirlister.h: Q_PRIVATE_SLOT(d, void _k_slotPercent(KJob *, unsigned long))
src/core/kcoredirlister.cpp | ||
---|---|---|
525 | This should probably not be here ;) |