Logical association (algorithm), implement keyboard controls and fix score overriding.
ClosedPublic

Authored by amankumargupta on Apr 12 2018, 10:52 AM.

Details

Summary

The selector area was previously coded as Row. It has been re-coded as GridView with a single row as it would be better and easy to have keyboard navigations with its internal keyboard properties.

Also the code have been reworked to resize elements on both width and height (previously was done only on width) as a result, the selector tray now doesn't override the bar and score overriding on vertical screens have been fixed too.

Screenshot before and after the changes:

  1. Previous overriding on widescreen: https://pasteboard.co/HgrJsvV.png
  1. After code rework: https://pasteboard.co/HgrJLg3.png
Test Plan
  1. Tested on PC screen on various dimensions. Result --> no overridings encountered.
  1. Tested on 4 and 5 inch mobiles. Result --> no overridings encountered.

Diff Detail

Repository
R2 GCompris
Lint
Lint Skipped
Unit
Unit Tests Skipped
Restricted Application added a project: KDE Edu. · View Herald TranscriptApr 12 2018, 10:52 AM
Restricted Application added a subscriber: KDE Edu. · View Herald Transcript
amankumargupta requested review of this revision.Apr 12 2018, 10:52 AM
timotheegiet requested changes to this revision.Apr 13 2018, 11:47 AM

There are still a few layout issues left, like on widescreen layout the bottom row is overlapping the menu bar;
and at some sizes between square and horizontal, it also overlaps a little the score box.

This revision now requires changes to proceed.Apr 13 2018, 11:47 AM
amankumargupta edited the summary of this revision. (Show Details)
timotheegiet requested changes to this revision.Apr 14 2018, 5:52 PM

Still not perfect at this size, you can surely find a solution to avoid this corner case:
https://pasteboard.co/HgBF5I4.png

Also, on a visual side, please set the border of the rectangle selector to white, and set its size a bit bigger than the items.

This revision now requires changes to proceed.Apr 14 2018, 5:52 PM

"rectangle selector" --> the highlight rectangle element?

ahh, sure! small changes, will be up in few minutes :)

I tried reproducing the small overriding like in the screenshot but couldn't. However, I hope it should be fine this time..

More changes did --> Highlight element size bit bigger than the images and border color changed to white.

amankumargupta edited the test plan for this revision. (Show Details)

Tested and Looks perfect on both - PC screens (on various possible dimensions) and mobile devices (4 and 5 inch screens).

No overridings encountered. I think it should be good now.

jjazeix accepted this revision.Apr 16 2018, 6:38 AM

good for me, when it's ok with Timothée, you can commit.

Thank you

timotheegiet accepted this revision.Apr 16 2018, 9:50 AM

Looks good to go now :)

Note: this activity also has the problem that one can still click on items during bonus, but that is a different issue...

This revision is now accepted and ready to land.Apr 16 2018, 9:50 AM