Differential D12136

Avoid hardcoding of filesystems supporting CoW
ClosedPublic
Actions

Authored by bruns on Apr 12 2018, 12:28 AM.

Details

Reviewers
adridg
Group Reviewers
Baloo
Commits
R293:5f3b8ead07eb: Avoid hardcoding of filesystems supporting CoW
Summary

The correct way to check for CoW support and conditionally disabling it
for the database is just by setting the NO_COW flag.

The CoW support is not only filesystem dependent, but is affected by
parameters at filesystem creation (XFS reflink) or mount time (BTRFS
nodatacow).

Test Plan

make
ctest

Diff Detail

Repository
R293 Baloo
Branch
disble_cow_unconditionally
Lint
No Linters Available
Unit
No Unit Test Coverage
bruns created this revision.Apr 12 2018, 12:28 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptApr 12 2018, 12:28 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
bruns requested review of this revision.Apr 12 2018, 12:28 AM
adridg accepted this revision.Apr 12 2018, 8:25 AM
This revision is now accepted and ready to land.Apr 12 2018, 8:25 AM
Closed by commit R293:5f3b8ead07eb: Avoid hardcoding of filesystems supporting CoW (authored by bruns). · Explain WhyApr 15 2018, 7:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/engine/database.cpp (4 lines)

Diff 31944

View Options

src/engine/database.cpp

Loading...