Futher Fixed Bug 391921 - Canvas position popping after pop-up palette rotation reset.
ClosedPublic

Authored by emmetoneill on Apr 11 2018, 10:55 PM.

Details

Summary

A couple weeks ago Dmitry fixed a bug to do with the canvas "popping/jumping" when panning just after using the pop-up palette to rotate.

https://bugs.kde.org/show_bug.cgi?id=391921

Someone (Piotr) mentioned that the bug was still present when the canvas rotation was reset, so I quickly piggy-backed off Dmitry's prior fix and fixed the rotation the same way (by using the canvas controller's rotation function there too).

While in that code I spent a few minutes cleaning up some unused #includes (there are probably some others in the header that could be swapped for forward declarations), whitespace inconsistencies, and other boring code style stuff. (Also, please let me know if doing this type of cleanup is more annoying than helpful!)

Test Plan

Try panning the canvas immediately after rotating and/or resetting the canvas rotation using the cool little slider in the pop-up palette. It should be relatively smooth!

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
emmetoneill created this revision.Apr 11 2018, 10:55 PM
Restricted Application added a subscriber: woltherav. · View Herald TranscriptApr 11 2018, 10:55 PM
emmetoneill requested review of this revision.Apr 11 2018, 10:55 PM
dkazakov accepted this revision.Apr 18 2018, 9:24 AM

Hi, @emmetoneill!

The patch looks and works fine! Thank you! I'll push it now :)

This revision is now accepted and ready to land.Apr 18 2018, 9:24 AM
This revision was automatically updated to reflect the committed changes.