Differential D12127

Do not query properties when no interfaces are left
Needs ReviewPublic
Actions

Authored by bruns on Apr 11 2018, 10:43 PM.

Details

Reviewers
broulik
Group Reviewers
Frameworks
Summary

checkCache is indirectly invoked from DeviceManager::updatebackend(),
e.g. after an InterfaceRemoved call. Avoid doing a DBus Get() call which
will never return a valid result.

Test Plan

make
solid-hardware5 list details

Diff Detail

Repository
R245 Solid
Branch
avoid_query_without_interfaces
Lint
No Linters Available
Unit
No Unit Test Coverage
bruns created this revision.Apr 11 2018, 10:43 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 11 2018, 10:43 PM
bruns requested review of this revision.Apr 11 2018, 10:43 PM
broulik added a subscriber: broulik.Apr 12 2018, 10:51 AM

Lgtm.
But do we remove the offending properties when the interface is removed? Not sure, is probably unrelated bug

bruns added a comment.Apr 12 2018, 7:43 PM
In D12127#244859, @broulik wrote:

Lgtm.
But do we remove the offending properties when the interface is removed? Not sure, is probably unrelated bug

Yes, D12126

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald TranscriptAug 18 2018, 4:34 PM
bruns added a comment.Aug 26 2018, 4:18 PM

This has been open for more than 4! months now ... 😒

Revision Contents
Changeset List

Diff 31933

View Options

src/solid/devices/backends/udisks2/udisksdevicebackend.cpp

Loading...