This patch basically adds the check that would normally be done to the
itemInserted method, which seems to be good idea in general.
However, the fact that this is needed there might be an indicator of a logic bug
in the function – though, as I'm not familiar with the code base I cannot judge
this.
Details
Details
- Reviewers
elvisangelaccio - Group Reviewers
Dolphin - Commits
- R318:3a028d9db0ee: use the same bound check as setCurrentItem when setting m_currentItem manually
Without this patch, dolphin when started from a terminal prints the following
warning (number can be different):
qt.accessibility.core: Cannot create accessible child interface for object: PlacesView(0x563e863e35c0) index: 10
After applying the patch, the warning doesn't appear anymore. Dolphin still
works still as it did before.
Diff Detail
Diff Detail
- Repository
- R318 Dolphin
- Branch
- annoyingAccessibilityWarning
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
I don't think there is a logic bug, this is just a missing check for an off-by-one error caused by the places panel (if you hide it, the warning is gone).
Do you have commit access?