Differential D11948

[KFileWidget] Hardcode example user name
ClosedPublic
Actions

Authored by broulik on Apr 5 2018, 7:56 AM.

Details

Reviewers
kfunk
Group Reviewers
Frameworks
Commits
R241:57b6b2d10131: [KFileWidget] Hardcode example user name
Summary

Don't create KUser() instance just for an example text in "What's This" mode.
When logged in via LDAP this can create quite some delay until the dialog opens.

Test Plan

Dialog opens quicker now, even on local login it spends 1ms in there for no real gain.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 5 2018, 7:56 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 5 2018, 7:56 AM
broulik requested review of this revision.Apr 5 2018, 7:56 AM
broulik added a comment.Apr 10 2018, 12:27 PM

Ping, if no one objects I'll push this once next FW is released

kfunk accepted this revision.Apr 10 2018, 4:17 PM
kfunk added a subscriber: kfunk.

Makes sense to me. Go for it.

This revision is now accepted and ready to land.Apr 10 2018, 4:17 PM
Closed by commit R241:57b6b2d10131: [KFileWidget] Hardcode example user name (authored by broulik). · Explain WhyApr 16 2018, 6:02 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/filewidgets/kfilewidget.cpp (5 lines)

Diff 32250

View Options

src/filewidgets/kfilewidget.cpp

Loading...