Prompt user if WinTab cannot be loaded
ClosedPublic

Authored by alvinhochun on Apr 3 2018, 4:59 PM.

Details

Reviewers
rempt
Group Reviewers
Krita
Summary

Prompt user if WinTab cannot be loaded and there are no WinInk pen devices.

Comments and improvements on the message box text will be appreciated. :)

(Since this adds strings, this will not target the 4.0 branch.)

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
alvinhochun created this revision.Apr 3 2018, 4:59 PM
Restricted Application added a subscriber: woltherav. · View Herald TranscriptApr 3 2018, 4:59 PM
alvinhochun requested review of this revision.Apr 3 2018, 4:59 PM
alvinhochun updated this revision to Diff 31223.
rempt added a subscriber: rempt.Apr 3 2018, 6:18 PM

Hm... I'm wondering, can we not just load the winink code silently if we don't find a wintab driver?

Hm... I'm wondering, can we not just load the winink code silently if we don't find a wintab driver?

I think it's better to let the user know. If the user hasn't installed the driver or it is not installed properly, silently switching to WinInk doesn't help the user realize the issue.

rempt added a comment.Apr 4 2018, 7:48 AM

Could we at least override that on systems where we know there's an n-trig pen like the surface? I'm worried that surface owners would get angry with us or confused if they get asked about wintab drivers.

It would be a bit tricky to detect N-Trig digitizers, but it should technically be doable. However, I would be reluctant to implement a special override for N-Trig digitizers. Some users might still want to install and use a Wacom tablet.

alvinhochun planned changes to this revision.Apr 11 2018, 7:14 PM
alvinhochun edited the summary of this revision. (Show Details)
  • Now automatically selects WinInk if there exists a WinInk pen device.
  • Changed the prompts.
rempt accepted this revision.Apr 15 2018, 6:43 PM
This revision is now accepted and ready to land.Apr 15 2018, 6:43 PM