Differential D11867

Logger overhaul
ClosedPublic
Actions

Authored by malteveerman on Apr 1 2018, 4:39 PM.

Details

Reviewers

markey

Group Reviewers

Amarok

Commits

R181:5f138b0fcc14: Logger overhaul

Summary

This moves ProxyLoggers functionality to the Logger base class and makes all important public functions static. Those functions then deliver the to be logged events to all objects of classes derived from Logger. This allows Amarok to have multiple Loggers.
I also added a DebugLogger which only gets build in debug mode and prints infos about all logged events to the console.

Diff Detail

Repository

R181 Amarok

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

malteveerman requested review of this revision.Apr 1 2018, 4:39 PM

malteveerman created this revision.

markey accepted this revision.Apr 4 2018, 4:35 PM

This revision is now accepted and ready to land.Apr 4 2018, 4:35 PM

Pushed to master.

Revision Contents
Changeset List

		Path
M		src/App.cpp (11 lines)
M		src/CMakeLists.txt (2 lines)
M		src/EngineController.cpp (4 lines)
M		src/browsers/BrowserDock.cpp (10 lines)
M		src/browsers/BrowserMessageArea.h (7 lines)
M		src/browsers/BrowserMessageArea.cpp (4 lines)
M		src/core-impl/collections/daap/DaapCollection.cpp (4 lines)
M		src/core-impl/collections/db/sql/SqlCollectionLocation.cpp (6 lines)
M		src/core-impl/collections/ipodcollection/IpodCollection.cpp (6 lines)
M		src/core-impl/collections/ipodcollection/IpodCollectionLocation.cpp (4 lines)
M		src/core-impl/collections/ipodcollection/IpodPlaylistProvider.cpp (4 lines)
M		src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.cpp (8 lines)
M		src/core-impl/collections/ipodcollection/jobs/IpodDeleteTracksJob.cpp (4 lines)
M		src/core-impl/collections/ipodcollection/jobs/IpodParseTracksJob.cpp (6 lines)
M		src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.cpp (10 lines)
M		src/core-impl/collections/mtpcollection/handler/MtpHandler.cpp (8 lines)
M		src/core-impl/collections/nepomukcollection/NepomukCollectionFactory.cpp (4 lines)
M		src/core-impl/collections/support/CollectionLocationDelegateImpl.cpp (4 lines)
M		src/core-impl/collections/support/FileCollectionLocation.cpp (4 lines)
M		src/core-impl/collections/support/TrashCollectionLocation.cpp (4 lines)
M		src/core-impl/collections/umscollection/UmsCollection.cpp (4 lines)
M		src/core-impl/collections/umscollection/UmsCollectionLocation.cpp (6 lines)
M		src/core-impl/collections/upnpcollection/UpnpBrowseCollection.cpp (6 lines)
A	M	src/core-impl/logger/DebugLogger.h (45 lines)
A	M	src/core-impl/logger/DebugLogger.cpp (81 lines)
D	M	src/core-impl/logger/ProxyLogger.h (112 lines)
D	M	src/core-impl/logger/ProxyLogger.cpp (188 lines)
M		src/core-impl/playlists/types/file/PlaylistFileLoaderJob.cpp (11 lines)
M		src/core-impl/playlists/types/file/PlaylistFileSupport.cpp (2 lines)
M		src/core-impl/podcasts/sql/SqlPodcastProvider.cpp (18 lines)
M		src/core/CMakeLists.txt (6 lines)
V		src/core/{interfaces → logger}/Logger.h
D	M	src/core/interfaces/Logger.cpp (17 lines)
V		src/core/{logger ← interfaces}/Logger.h (73 lines)
A	M	src/core/logger/Logger.cpp (186 lines)
M		src/core/support/Components.h (4 lines)
M		src/core/support/Components.cpp (4 lines)
M		src/covermanager/CoverFetcher.cpp (15 lines)
M		src/dialogs/TagDialog.cpp (2 lines)
M		src/dynamic/BiasedPlaylist.cpp (4 lines)
M		src/playlist/PlaylistActions.cpp (2 lines)
M		src/playlist/PlaylistRestorer.cpp (2 lines)
M		src/playlist/layouts/LayoutManager.cpp (4 lines)
M		src/playlistgenerator/ConstraintSolver.cpp (6 lines)
M		src/playlistgenerator/Preset.cpp (6 lines)
M		src/playlistgenerator/PresetModel.cpp (10 lines)
M		src/playlistmanager/PlaylistManager.cpp (2 lines)
M		src/playlistmanager/file/PlaylistFileProvider.cpp (4 lines)
M		src/scanner/AbstractScanResultProcessor.cpp (13 lines)
M		src/scripting/scriptengine/AmarokStatusbarScript.cpp (6 lines)
M		src/scripting/scriptmanager/ScriptItem.cpp (4 lines)
M		src/scripting/scriptmanager/ScriptManager.cpp (4 lines)
M		src/services/ampache/AmpacheAccountLogin.cpp (2 lines)
M		src/services/ampache/AmpacheService.cpp (2 lines)
M		src/services/gpodder/GpodderProvider.cpp (10 lines)
M		src/services/jamendo/JamendoService.cpp (6 lines)
M		src/services/jamendo/JamendoXmlParser.cpp (4 lines)
M		src/services/lastfm/LastFmService.cpp (6 lines)
M		src/services/lastfm/LastFmServiceConfig.cpp (4 lines)
M		src/services/lastfm/ScrobblerAdapter.cpp (8 lines)
M		src/services/lastfm/meta/LastFmMultiPlayableCapability.h (1 line)
M		src/services/lastfm/meta/LastFmMultiPlayableCapability.cpp (4 lines)
M		src/services/magnatune/MagnatuneAlbumDownloader.cpp (10 lines)
M		src/services/magnatune/MagnatuneDownloadHandler.cpp (4 lines)
M		src/services/magnatune/MagnatuneInfoParser.cpp (10 lines)
M		src/services/magnatune/MagnatuneRedownloadHandler.cpp (4 lines)
M		src/services/magnatune/MagnatuneStore.cpp (8 lines)
M		src/services/magnatune/MagnatuneXmlParser.cpp (4 lines)
M		src/services/mp3tunes/Mp3tunesService.cpp (20 lines)
M		src/services/mp3tunes/Mp3tunesServiceCollectionLocation.cpp (4 lines)
M		src/services/mp3tunes/Mp3tunesWorkers.cpp (4 lines)
M		src/services/opmldirectory/OpmlDirectoryInfoParser.cpp (4 lines)
M		src/services/opmldirectory/OpmlDirectoryService.cpp (2 lines)
M		src/statemanagement/DefaultApplicationController.h (1 line)
M		src/statemanagement/DefaultApplicationController.cpp (15 lines)
M		src/statsyncing/Controller.cpp (4 lines)
M		src/statsyncing/Process.cpp (8 lines)
M		src/statusbar/LongMessageWidget.h (2 lines)
M		tests/core-impl/CMakeLists.txt (1 line)
M		tests/core-impl/collections/db/sql/CMakeLists.txt (4 lines)
M		tests/core-impl/collections/db/sql/TestSqlCollectionLocation.cpp (3 lines)
D	M	tests/core-impl/logger/CMakeLists.txt (35 lines)
V		tests/{core-impl/logger/TestProxyLogger.h → core/logger/TestLogger.h}
V		tests/{core-impl/logger/TestProxyLogger.cpp → core/logger/TestLogger.cpp}
M		tests/core/CMakeLists.txt (1 line)
A	M	tests/core/logger/CMakeLists.txt (34 lines)
V		tests/{core/logger/TestLogger.h ← core-impl/logger/TestProxyLogger.h} (8 lines)
V		tests/{core/logger/TestLogger.cpp ← core-impl/logger/TestProxyLogger.cpp} (66 lines)
M		tests/mocks/MockLogger.h (10 lines)

Commit	Tree	Parents	Author	Summary	Date
4ccee5eb3253	0187acfe1ec5	4b526f9a3845	Malte Veerman	Added DebugLogger	Mar 29 2018, 9:34 PM
4b526f9a3845	c933596b8398	5176c93e41e4	Malte Veerman	Integrated ProxyLogger's functionality in Logger and moved it out of interfaces. (Show More…)	Mar 29 2018, 5:00 PM

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	31103	5176c93		Apr 1 2018, 4:29 PM	★	★

Logger overhaulClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 31103

src/App.cpp

src/CMakeLists.txt

src/EngineController.cpp

src/browsers/BrowserDock.cpp

src/browsers/BrowserMessageArea.h

src/browsers/BrowserMessageArea.cpp

src/core-impl/collections/daap/DaapCollection.cpp

src/core-impl/collections/db/sql/SqlCollectionLocation.cpp

src/core-impl/collections/ipodcollection/IpodCollection.cpp

src/core-impl/collections/ipodcollection/IpodCollectionLocation.cpp

src/core-impl/collections/ipodcollection/IpodPlaylistProvider.cpp

src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.cpp

src/core-impl/collections/ipodcollection/jobs/IpodDeleteTracksJob.cpp

src/core-impl/collections/ipodcollection/jobs/IpodParseTracksJob.cpp

src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.cpp

src/core-impl/collections/mtpcollection/handler/MtpHandler.cpp

src/core-impl/collections/nepomukcollection/NepomukCollectionFactory.cpp

src/core-impl/collections/support/CollectionLocationDelegateImpl.cpp

src/core-impl/collections/support/FileCollectionLocation.cpp

src/core-impl/collections/support/TrashCollectionLocation.cpp

src/core-impl/collections/umscollection/UmsCollection.cpp

src/core-impl/collections/umscollection/UmsCollectionLocation.cpp

src/core-impl/collections/upnpcollection/UpnpBrowseCollection.cpp

src/core-impl/logger/DebugLogger.h

src/core-impl/logger/DebugLogger.cpp

src/core-impl/logger/ProxyLogger.h

src/core-impl/logger/ProxyLogger.cpp

src/core-impl/playlists/types/file/PlaylistFileLoaderJob.cpp

src/core-impl/playlists/types/file/PlaylistFileSupport.cpp

src/core-impl/podcasts/sql/SqlPodcastProvider.cpp

src/core/CMakeLists.txt

src/core/interfaces/Logger.h

src/core/interfaces/Logger.cpp

src/core/logger/Logger.h

src/core/logger/Logger.cpp

src/core/support/Components.h

src/core/support/Components.cpp

src/covermanager/CoverFetcher.cpp

src/dialogs/TagDialog.cpp

src/dynamic/BiasedPlaylist.cpp

src/playlist/PlaylistActions.cpp

src/playlist/PlaylistRestorer.cpp

src/playlist/layouts/LayoutManager.cpp

src/playlistgenerator/ConstraintSolver.cpp

src/playlistgenerator/Preset.cpp

src/playlistgenerator/PresetModel.cpp

src/playlistmanager/PlaylistManager.cpp

src/playlistmanager/file/PlaylistFileProvider.cpp

src/scanner/AbstractScanResultProcessor.cpp

src/scripting/scriptengine/AmarokStatusbarScript.cpp

src/scripting/scriptmanager/ScriptItem.cpp

src/scripting/scriptmanager/ScriptManager.cpp

src/services/ampache/AmpacheAccountLogin.cpp

src/services/ampache/AmpacheService.cpp

src/services/gpodder/GpodderProvider.cpp

src/services/jamendo/JamendoService.cpp

src/services/jamendo/JamendoXmlParser.cpp

src/services/lastfm/LastFmService.cpp

src/services/lastfm/LastFmServiceConfig.cpp

src/services/lastfm/ScrobblerAdapter.cpp

src/services/lastfm/meta/LastFmMultiPlayableCapability.h

src/services/lastfm/meta/LastFmMultiPlayableCapability.cpp

src/services/magnatune/MagnatuneAlbumDownloader.cpp

src/services/magnatune/MagnatuneDownloadHandler.cpp

src/services/magnatune/MagnatuneInfoParser.cpp

src/services/magnatune/MagnatuneRedownloadHandler.cpp

src/services/magnatune/MagnatuneStore.cpp

src/services/magnatune/MagnatuneXmlParser.cpp

src/services/mp3tunes/Mp3tunesService.cpp

src/services/mp3tunes/Mp3tunesServiceCollectionLocation.cpp

src/services/mp3tunes/Mp3tunesWorkers.cpp

src/services/opmldirectory/OpmlDirectoryInfoParser.cpp

src/services/opmldirectory/OpmlDirectoryService.cpp

src/statemanagement/DefaultApplicationController.h

src/statemanagement/DefaultApplicationController.cpp

Logger overhaul
ClosedPublic
Actions

Revision Contents
Changeset List