[weather dataengine] Fix BBC provider to adapt to change RSS feed
ClosedPublic

Authored by kossebau on Mar 30 2018, 3:14 PM.

Details

Summary

The urls of the BBC weather feeds seem to have changed, resulting in the
dataengine to use no longer existing urls.

I could not find the change documented somewhere and also do not know about
a contact person with BBC, so done based on examples on website, trial &
error.
There are some data issues visible in the new data feeds, so chance is the
feeds might see more rework and might break things again. But without any
contract or formal agreement we can just play catch-up.

BUG: 392510

Test Plan

Existing configured weather applets using a location from a BBC weather
service work again.
Newly configured weather applets using a BBC weather service also work.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Mar 30 2018, 3:14 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 30 2018, 3:14 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kossebau requested review of this revision.Mar 30 2018, 3:14 PM

The old RSS feed disappeared the last days, so this needs to go to Plasma/5.12 and also be pointed at to the distributions as hotfix, as any existing weather applets using the BBC weather service will continue to fail without this patch.

Hoping for some feedback until tomorrow afternoon. Without any will then commit and notice the packagers, given chance is low someone else has insight into the weather dataengine and the bbcukmet ion special dataengine :)

cfeck accepted this revision.Mar 30 2018, 8:49 PM
cfeck added a subscriber: cfeck.

You cannot break what no longer works :)

dataengines/weather/ions/bbcukmet/ion_bbcukmet.cpp
270

Space after +

This revision is now accepted and ready to land.Mar 30 2018, 8:49 PM
This revision was automatically updated to reflect the committed changes.
kossebau marked an inline comment as done.