| jjazeix | |
| timotheegiet |
| GCompris: Activities |
In the activity "explore_farm_animals", in level 2, when the choice is correct, play first a jingle before the next animal sound.
It is disturbing the click on an animal and to hear directly the sound of another one.
The source of the sound is https://opengameart.org/content/completion-sound (CC-BY 3.0)
| Lint Skipped |
| Unit Tests Skipped |
I must say that I tried to play first the jingle and the animal sound with two files but I didn't succeed. That's why I choose the strategy to play a different file when the user select the correct animal.
Hi,
thank you for your patch. I think it can be simplified without adding to add too much code.
Johnny
| src/activities/explore_farm_animals/explore-level.js | ||
|---|---|---|
| 122 | why not using directly "silence" property of GCAudio (https://cgit.kde.org/gcompris.git/tree/src/core/GCAudio.qml#n168)? | |
| 132 | if it's a boolean value, better use true/false | |
Surely no need to add duplicate delayed ogg files.
Also, for the sound choice, I think we can reuse the same as in the melody activity (the "knock knock knock").
For the audio file I thought about the knock-knock before playing a new animal sound, but for a good answer feedback as you suggest this new sound can work as base.
However I would only keep the first "bleep" part, without the second part with piano notes.
I have no hard feeling with my patch, changes are welcome. I just thought that my point would be more clear with a patch. :-)
just to be sure on our side :). Is it more a feature request with a potential solution (up to us to improve and fit inside GCompris) or do you plan to complete the full change?
The request is valid as it would be better to have at least a small pause before playing the next sound so we can continue your patch to integrate it if needed.
Héhé yes :)
I also noticed that issue while fixing the layout on this activity recently, and planned to fix it at some point.
So, thanks again for the patch, it's a good first step in the discussion.
If you can try to adapt the changes according to our comments that would be great.
Else we will do the needed changes to fix the issue.
I already tried to play one sound after the other but I didn't succeed. So, yes, it's more a feature request.
The request is valid as it would be better to have at least a small pause before playing the next sound so we can continue your patch to integrate it if needed.