Make the key binding editor dialog bigger
ClosedPublic

Authored by ahmadsamir on Mar 24 2018, 9:18 AM.

Details

Summary

The first column in the key binding editor dialog usually has long lines of
text, to improve usability set a minimum size of 480x430 for that dialog
and an initial size of 500x500. Also set the initial width of that column
to 300.

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Mar 24 2018, 9:18 AM
Restricted Application added a project: Konsole. · View Herald TranscriptMar 24 2018, 9:18 AM
ahmadsamir requested review of this revision.Mar 24 2018, 9:18 AM

Before:


After:

The only issue is that I've been trying to get the dialogs to be small enough to be usable on a small screen 600 high; I'd rather not have this dialog that big in height.

ahmadsamir updated this revision to Diff 30403.EditedMar 24 2018, 4:01 PM

I was careful not to make it bigger than the Edit Profile dialog, but it's still ok if it's shorter, I've changed it to make the initial height of the dialog 500px.

hindenburg edited the summary of this revision. (Show Details)Mar 24 2018, 5:07 PM

So 'arc diff' doesn't update the summary based on the new commit message done with 'git commit --amend'....

So 'arc diff' doesn't update the summary based on the new commit message done with 'git commit --amend'....

You want arc diff --edit --verbatim

See https://community.kde.org/Infrastructure/Phabricator#Updating_the_summary_of_the_Differential_from_the_local_Git_commit_message

hindenburg accepted this revision.Mar 24 2018, 7:54 PM
This revision is now accepted and ready to land.Mar 24 2018, 7:54 PM
This revision was automatically updated to reflect the committed changes.