[shell] Set FramelessWindowHint on DesktopView by default
ClosedPublic

Authored by graesslin on Mar 16 2016, 3:01 PM.

Details

Summary

The default window type is desktop, so we should also tell Qt that it's
a frameless window. Not doing so means that on construction of the
platform surface our plasma-integration plugin will request a server
side decoration for the window. Which means KWin creates a deco and
destroys it again once the flag propagated. But it also means that the
window gets misplaced due to the temporarily added deco.

By setting the flag the plasma-integration never asks for the deco to
be created in the first place and in all my tests so far the window was
positioned correctly.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 2806.Mar 16 2016, 3:01 PM
graesslin retitled this revision from to [shell] Set FramelessWindowHint on DesktopView by default.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: Plasma, sebas, mart.
Restricted Application added a project: Plasma. · View Herald TranscriptMar 16 2016, 3:01 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sebas accepted this revision.Mar 16 2016, 9:33 PM
sebas edited edge metadata.

Good catch!

This revision is now accepted and ready to land.Mar 16 2016, 9:33 PM
This revision was automatically updated to reflect the committed changes.
broulik added inline comments.
shell/desktopview.cpp
48

Isn't there a Qt::Desktop window flag?