frameworks 5.43 changed the list-remove icon, and 5.44 changed the icon we use for the tracks to a colorized version, breaking look and feel and color overlays.
workaround by using different icons.
Details
Details
- Reviewers
mgallien - Group Reviewers
Elisa - Commits
- R255:e13beaeef172: adjust icons for playlist and view selector
Diff Detail
Diff Detail
- Repository
- R255 Elisa
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Before:
After
I like the old icon for the track view better, and while I'll try to resolve this in breeze-icons, framework 5.44 is out and we will have to cope with
Comment Actions
Thanks for working on this.
I agree that using view-media-title is a good idea. On the other hand, I kind of prefer the icon for list-remove. We should try to find a way to have the workaround only when necessary.
We have the same need for the application icon that will be part of v45 release.
Comment Actions
You mean the new icon ( "-") or the old error icon? I just tried, we can still use the error icon when adjusting the icon name, it is now just monochrome. The "dialog-close" icon nicely aligns it with e.g. plasma's notification system, though, that's why I changed it.
Comment Actions
Sorry for my late answer. We will make sure that a fix is present in the release.
I was hesitating about this.
I am thinking that we could also embed a copy of the old icons into our qrc file. What do you think ?
Did you get any answer about this change and a solution for us ?
Comment Actions
I was trying to avoid embedding icons. The last time I tried it (for my preliminary tryouts for T8249), the icons embedded by Elisa had a slightly different color due to theming, which didn't look good then.
My plan was to work around with this revision for the 0.1 release, and then require as soon as possible KF 5.45 and revisit all icons. There are quite many changes in breeze-icons that are relevant for us. My hope is also to get my two revisions into frameworks in time for 5.45.
Unfortunately, I'm not getting any replies there currently. Also, I don't think that the list-remove icon will be changed back (though I haven't asked), so we have to cope with this one anyway. The new icon is actually more appropriate for its name.
Comment Actions
OK, we can try this approach. We have to make sure that this do not break too much for people using different icons theme.
Unfortunately, I'm not getting any replies there currently. Also, I don't think that the list-remove icon will be changed back (though I haven't asked), so we have to cope with this one anyway. The new icon is actually more appropriate for its name.
Did you try asking on the irc/telegram vdg channel ?
@vdg this issue is really important for us and we would like to reach a working solution for you and for us. Is somebody able to guide and help us ?