Differential D11360

provide sample rate in kHz
ClosedPublic
Actions

Authored by astippich on Mar 15 2018, 6:27 PM.

Details

Reviewers
elvisangelaccio
Group Reviewers
Baloo
Commits
R824:507cb3f6dcd4: provide sample rate in kHz
Summary

gives the sample rate a proper unit and displays it in a more readable way

Diff Detail

Repository
R824 Baloo Widgets
Branch
sample_rate
Lint
No Linters Available
Unit
No Unit Test Coverage
astippich created this revision.Mar 15 2018, 6:27 PM
Restricted Application added a project: Baloo. · View Herald TranscriptMar 15 2018, 6:27 PM
astippich requested review of this revision.Mar 15 2018, 6:27 PM
astippich added a comment.Mar 15 2018, 6:28 PM

before

after

in the lower right corner

elvisangelaccio added a subscriber: elvisangelaccio.Mar 15 2018, 8:40 PM
elvisangelaccio added inline comments.
src/widgetfactory.cpp
126 ↗(On Diff #29621)

Please use QLatin1String for comparisons.

127 ↗(On Diff #29621)

This could show "48,0 kHz". Is that what we want?

Also, please add spaces before/after the division operator.

astippich updated this revision to Diff 29662.Mar 16 2018, 7:17 AM
  • use qlatin1string for comparison and do not display trailing zeros
elvisangelaccio requested changes to this revision.Mar 18 2018, 10:25 AM
elvisangelaccio added inline comments.
src/widgetfactory.cpp
122–124

Please only one change per commit. I meant to use QLatin1String only for the new sampleRate prop.

I just fixed these 2 on master, please rebase this patch on top of it.

125

This should go in another commit.

This revision now requires changes to proceed.Mar 18 2018, 10:25 AM
astippich added inline comments.Mar 18 2018, 10:47 AM
src/widgetfactory.cpp
122–124

Okay, sorry. I thought to fix everything while I'm at it. Will rebase and also make a new commit for the bitrate tonight.

astippich updated this revision to Diff 29838.Mar 18 2018, 6:29 PM
  • rebase and remove unrelated changes
elvisangelaccio accepted this revision.Mar 18 2018, 7:00 PM
This revision is now accepted and ready to land.Mar 18 2018, 7:00 PM
Closed by commit R824:507cb3f6dcd4: provide sample rate in kHz (authored by astippich). · Explain WhyMar 18 2018, 7:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/widgetfactory.cpp (8 lines)

Diff 29662

View Options

src/widgetfactory.cpp

Loading...