Differential D11340

artist, album artist, genre composer and lyricist can be strings list: fix Elisa
ClosedPublic
Actions

Authored by mgallien on Mar 14 2018, 8:23 PM.

Details

Reviewers
astippich
Group Reviewers
Elisa
Commits
R255:b2b338bc5385: artist, album artist, genre composer and lyricist can be strings list: fix Elisa
R255:ddf1354ee8dd: artist, album artist, genre composer and lyricist can be strings list: fix Elisa
Summary

artist, album artist, genre composer and lyricist can be strings list: fix Elisa

Test Plan

tests are OK and more metadata are recognised by Elisa

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mgallien requested review of this revision.Mar 14 2018, 8:23 PM
mgallien created this revision.
astippich accepted this revision.Mar 14 2018, 9:13 PM
astippich added a subscriber: astippich.

Better than what Elisa is currently doing. It would be nice to store the fields individually, though, at least for some. But probably something for the future.

This revision is now accepted and ready to land.Mar 14 2018, 9:13 PM
Closed by commit R255:b2b338bc5385: artist, album artist, genre composer and lyricist can be strings list: fix Elisa (authored by mgallien). · Explain WhyMar 15 2018, 4:34 PM
This revision was automatically updated to reflect the committed changes.
mgallien added a comment.Mar 15 2018, 9:10 PM
In D11340#225936, @astippich wrote:

Better than what Elisa is currently doing. It would be nice to store the fields individually, though, at least for some. But probably something for the future.

I am already working on that but only for master and not to be part of 0.1 release.

Revision Contents
Changeset List

PathPackages
Msrc/baloo/localbaloofilelisting.cpp (14 lines)
Msrc/elisautils.cpp (14 lines)

Diff 29610

View Options

src/baloo/localbaloofilelisting.cpp

Loading...
View Options

src/elisautils.cpp

Loading...