Differential D11326

[ToolTip] Check file name in KDirWatch handler
ClosedPublic
Actions

Authored by broulik on Mar 14 2018, 12:23 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R242:77bac859bcec: [ToolTip] Check file name in KDirWatch handler
Summary

KDirWatch::self() is a singleton so we would get change events also for other files like plasma-appletsrc needlessly reloading plasmarc all the time.

Test Plan

It reloaded plasmarc 103 times on startup for me, now it only does it like 3 times

  • Verified that enabling and disabling tooltips in workspace options still updates tooltip

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 14 2018, 12:23 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 14 2018, 12:23 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
broulik requested review of this revision.Mar 14 2018, 12:23 PM
broulik edited the test plan for this revision. (Show Details)
mart accepted this revision.Mar 15 2018, 11:16 AM
This revision is now accepted and ready to land.Mar 15 2018, 11:16 AM
Closed by commit R242:77bac859bcec: [ToolTip] Check file name in KDirWatch handler (authored by broulik). · Explain WhyMar 15 2018, 11:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 29584

View Options

src/declarativeimports/core/tooltip.h

Loading...
View Options

src/declarativeimports/core/tooltip.cpp

Loading...