BUG : 365420
Details
Details
Diff Detail
Diff Detail
- Repository
- R32 KDevelop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
plugins/clang/codegen/adaptsignatureassistant.cpp | ||
---|---|---|
59 | Only need to lock here, no? Or at least after the if. |
Comment Actions
Looks good to me, thanks!
plugins/clang/codegen/adaptsignatureassistant.cpp | ||
---|---|---|
59 | Yeah but the macro is not a lock, just an assert. If you expect the function to be called with the lock, it IMO makes sense to put it on the top. |
plugins/clang/codegen/adaptsignatureassistant.cpp | ||
---|---|---|
49 | bool isConstructor(const Declaration *functionDecl) { auto classFun = dynamic_cast<const ClassFunctionDeclaration*>(DUChainUtils::declarationForDefinition(functionDecl)); return classFun && classFun->isConstructor(); } |