Remove Desktop.SystemSettings import
ClosedPublic
Actions

Authored by drosca on Mar 11 2016, 9:09 PM.

Details

Reviewers

davidedmundson
sebas

Group Reviewers

Plasma

Commits

R119:2acf6b8c4225: Remove Desktop.SystemSettings import

Summary

Port to Qt.styleHints (Qt >= 5.5)

Diff Detail

Repository

R119 Plasma Desktop

Branch

stylehints (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

drosca updated this revision to Diff 2723.Mar 11 2016, 9:09 PM

drosca retitled this revision from to Remove Desktop.SystemSettings import.

drosca updated this object.

drosca edited the test plan for this revision. (Show Details)

drosca added a reviewer: Plasma.

Restricted Application added a project: Plasma. · View Herald TranscriptMar 11 2016, 9:09 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

To me, this looks like something we want. @mart could you have a look as well?

sebas requested changes to this revision.May 5 2016, 1:09 AM

sebas added a reviewer: sebas.

sebas added inline comments.

containments/desktop/package/contents/ui/main.qml
218 ↗	(On Diff #2723)	this should be => (otherwise, the drag won't start at startDragDistance, but only at startDragDistance+1

This revision now requires changes to proceed.May 5 2016, 1:09 AM

fine for me, modulo just the >=

I've only just seen this. I just duplicated the same thing :(
That's a bit of a waste.

Drosca, what happened with merging this? So that we can make sure this doesn't happen again.
Make sure to ping me on IRC if things get stuck in review.

Also, obviously you can merge this. I'll throw away mine.

Closed by commit R119:2acf6b8c4225: Remove Desktop.SystemSettings import (authored by drosca). · Explain WhyAug 28 2016, 3:06 PM

This revision was automatically updated to reflect the committed changes.

@davidedmundson What happened? I think I updated the diff, waited for review and then just forgot, sorry. It won't happen again.

Revision Contents
Changeset List

		Path
M		containments/desktop/package/contents/ui/AppletAppearance.qml (2 lines)
M		containments/desktop/package/contents/ui/ConfigIcons.qml (8 lines)
M		containments/desktop/package/contents/ui/FolderItemDelegate.qml (2 lines)
M		containments/desktop/package/contents/ui/FolderView.qml (8 lines)
M		containments/desktop/package/contents/ui/main.qml (12 lines)
M		containments/desktop/plugins/desktop/CMakeLists.txt (1 line)
M		containments/desktop/plugins/desktop/desktopplugin.cpp (2 lines)
D	M	containments/desktop/plugins/desktop/systemsettings.h (44 lines)
D	M	containments/desktop/plugins/desktop/systemsettings.cpp (56 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	2723	271719d		Mar 11 2016, 9:09 PM	★	★
Diff 2	3655	dd67a42	>=	May 6 2016, 7:13 AM	★	★
Diff 3	6339	6ba90e0	rPLASMADESKTOP2acf6b8c42250d745d703a9bc7fbb36d30b8eb75	Aug 28 2016, 3:00 PM	★	★