Actually vote when clicking stars in the list view
ClosedPublic

Authored by leinir on Mar 9 2018, 9:34 AM.

Details

Summary

This connects up the ratings widget in the list view delegate with the engine, using the same vote logic found in the details view

This code has been missing for what i can only assume is a very long time. Nobody will have known, because the ratings widget updates its view immediately and only then sends the request off for voting.

BUG: 391112

Test Plan

Without patch: Only view updates when clicking stars in the item details view
With patch: Request is sent to the newstuff engine to perform a vote

Diff Detail

Repository
R304 KNewStuff
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
leinir created this revision.Mar 9 2018, 9:34 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 9 2018, 9:34 AM
leinir requested review of this revision.Mar 9 2018, 9:34 AM
leinir retitled this revision from Actually vote when clicking stars in the details view to Actually vote when clicking stars in the list view.Mar 9 2018, 9:51 AM
leinir edited the summary of this revision. (Show Details)
apol accepted this revision.Mar 9 2018, 11:31 AM
This revision is now accepted and ready to land.Mar 9 2018, 11:31 AM
This revision was automatically updated to reflect the committed changes.
firef awarded a token.Jun 13 2018, 9:02 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald TranscriptJun 13 2018, 9:02 AM