Differential D11150

Use Kirigami's spacing and icon sizes and remove own implementation
ClosedPublic
Actions

Authored by malteveerman on Mar 8 2018, 9:51 AM.

Details

Reviewers

markey

Group Reviewers

Amarok

Commits

R181:459ed3a342f0: Use Kirigami's spacing and icon sizes and remove own implementation

Summary

This patch removes some redundant functionality from ContextView and makes the QML parts instead rely on KF5::Kirigami2. Also adds Kirigami as runtime package.

Diff Detail

Repository

R181 Amarok

Branch

kf5

Lint

Lint Skipped

Unit

Unit Tests Skipped

malteveerman requested review of this revision.Mar 8 2018, 9:51 AM

malteveerman created this revision.

Kirigami2 seems really nifty. Nice choice.

This revision is now accepted and ready to land.Mar 9 2018, 3:48 AM

markey closed this revision.Mar 9 2018, 3:49 AM

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (6 lines)
M			src/context/ContextView.h (31 lines)
M			src/context/ContextView.cpp (98 lines)
M			src/context/applets/analyzer/package/contents/ui/main.qml (5 lines)
M			src/context/applets/currenttrack/package/contents/ui/InfoItem.qml (3 lines)
M			src/context/applets/currenttrack/package/contents/ui/StatsItem.qml (3 lines)
M			src/context/applets/currenttrack/package/contents/ui/main.qml (7 lines)
M			src/context/applets/info/package/contents/ui/main.qml (5 lines)
M			src/context/applets/photos/package/contents/ui/main.qml (3 lines)
M			src/context/applets/wikipedia/package/contents/ui/main.qml (149 lines)
M			src/context/context_qml_package/contents/ui/main.qml (5 lines)
M			src/context/context_qml_package/contents/ui/toolbar/AppletToolbar.qml (6 lines)
M			src/context/context_qml_package/contents/ui/toolbar/AppletToolbarAddItem.qml (13 lines)
M			src/context/context_qml_package/contents/ui/toolbar/AppletToolbarAppletItem.qml (15 lines)
M			src/context/qml_plugin/Applet.qml (8 lines)