[XWindowTasksModel] When name or visible name changed only update display role
ClosedPublic

Authored by broulik on Mar 6 2018, 1:02 PM.

Details

Summary

The window name and user visible name are not used in the app identification heuristic, so a change here cannot result in the icon, app id, app name, generic name, PID or launcher changing.

Test Plan

Changed files in Qt Creator, noticed that it also erroneously signals a geometry change, when I ignored that, I verified that it was the name change code path updating the label and not the geometry one (which also nukes app info cache)

Also verified that the icon isn't always signalled to have changed just because the window name changed (can be expensive for apps where we don't know the service and have to query the window icon)

Inspected TaskTools namespace and didn't find any use of KWindowInfo (and as such no use of window name/visible name)

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Mar 6 2018, 1:02 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 6 2018, 1:02 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Mar 6 2018, 1:02 PM
hein accepted this revision.Mar 6 2018, 1:19 PM
This revision is now accepted and ready to land.Mar 6 2018, 1:19 PM
This revision was automatically updated to reflect the committed changes.