Convert EffectView to a QQuickWidget
ClosedPublic

Authored by fvogt on Mar 5 2018, 7:03 PM.

Details

Summary

The Qt Wayland support for subsurfaces is broken in many ways, producing
graphical glitches and crashes:
https://bugreports.qt.io/browse/QTBUG-54888 for instance.

Using a QQuickWidget instead of a QQuickView avoids those issues, with
the additional benefit of a nicer API.

Test Plan

Opened the KCM with kcmshell and systemsettings, no subsurfaces used
anymore.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
fvogt created this revision.Mar 5 2018, 7:03 PM
Restricted Application added a project: KWin. · View Herald TranscriptMar 5 2018, 7:03 PM
Restricted Application added subscribers: KWin, kwin. · View Herald Transcript
fvogt requested review of this revision.Mar 5 2018, 7:03 PM
davidedmundson accepted this revision.Mar 5 2018, 7:05 PM
This revision is now accepted and ready to land.Mar 5 2018, 7:05 PM
fvogt added a comment.Mar 5 2018, 7:07 PM

I won't land this now to give @graesslin a chance to review this as well.

graesslin accepted this revision.Mar 5 2018, 8:50 PM
This revision was automatically updated to reflect the committed changes.