Convert EffectView to a QQuickWidget
ClosedPublic
Actions

Authored by fvogt on Mar 5 2018, 7:03 PM.

Details

Reviewers

graesslin
davidedmundson

Group Reviewers

Plasma

Commits

R108:68a2ec5d6365: Convert EffectView to a QQuickWidget

Summary

The Qt Wayland support for subsurfaces is broken in many ways, producing
graphical glitches and crashes:
https://bugreports.qt.io/browse/QTBUG-54888 for instance.

Using a QQuickWidget instead of a QQuickView avoids those issues, with
the additional benefit of a nicer API.

Test Plan

Opened the KCM with kcmshell and systemsettings, no subsurfaces used
anymore.

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a project: KWin. · View Herald TranscriptMar 5 2018, 7:03 PM

Restricted Application added subscribers: KWin, kwin. · View Herald Transcript

fvogt requested review of this revision.Mar 5 2018, 7:03 PM

This revision is now accepted and ready to land.Mar 5 2018, 7:05 PM

I won't land this now to give @graesslin a chance to review this as well.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			kcmkwin/kwincompositing/CMakeLists.txt (2 lines)
M			kcmkwin/kwincompositing/main.cpp (8 lines)
M			kcmkwin/kwincompositing/model.h (6 lines)
M			kcmkwin/kwincompositing/model.cpp (6 lines)