Differential D11045

Use QQuickWidget instead of QQuickView for the main view in the kcm
ClosedPublic
Actions

Authored by fvogt on Mar 5 2018, 9:51 AM.

Details

Reviewers
sebas
dvratil
davidedmundson
Group Reviewers
Plasma
Commits
R104:47521b011d33: Use QQuickWidget instead of QQuickView for the main view in the kcm
Summary

This makes it usable on wayland. The Qt Wayland support for subsurfaces
is broken in many ways, producing practically unusuable graphics and crashes.
https://bugreports.qt.io/browse/QTBUG-54888 for instance.

Test Plan

Used it on wayland works fine now.

Diff Detail

Repository
R104 KScreen
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
fvogt created this revision.Mar 5 2018, 9:51 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 5 2018, 9:51 AM
fvogt requested review of this revision.Mar 5 2018, 9:51 AM
davidedmundson accepted this revision.Mar 5 2018, 11:47 AM
davidedmundson added a subscriber: davidedmundson.

Thanks for finding a simple fix for this, it was super annoying.

This revision is now accepted and ready to land.Mar 5 2018, 11:47 AM
Closed by commit R104:47521b011d33: Use QQuickWidget instead of QQuickView for the main view in the kcm (authored by fvogt). · Explain WhyMar 5 2018, 12:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcm/qml/main.qml (2 lines)
Mkcm/src/widget.h (3 lines)
Mkcm/src/widget.cpp (9 lines)

Diff 28696

View Options

kcm/qml/main.qml

Loading...
View Options

kcm/src/widget.h

Loading...
View Options

kcm/src/widget.cpp

Loading...