The window rules dialog did not properly detect the wayland windows. So
I investigated what ICCCM writes about the WM_CLASS property (which is
the base for window rule matching) and checked how ShellClient maps to
it. Basically name and class was swapped and the reason for the
detection not working properly. As we don't have a proper name, the code
is adjusted to generate a name by using the executable name. This is
also what WM_CLASS should be filled with, according to ICCCM.
Details
Details
- Reviewers
davidedmundson romangg - Group Reviewers
KWin Plasma - Commits
- R108:ab18007d2a62: Better map ShellClient to resource name and class
Rules dialog detects the name and class correctly
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| shell_client.cpp | ||
|---|---|---|
| 132 | Could you rename this variable to fileInfo or something? There is already a protected info member variable in Toplevel, that is inherited to child classes. | |
| shell_client.cpp | ||
|---|---|---|
| 132 | I don't think that really matters. the protected Toplevel::info is an X11 only variable which results in a crash when using in ShellClient. So from reading code it is obvious that the Toplevel one cannot be meant as that just doesn't make sense. Also long term plan would be to get rid of the info from Toplevel as it created various problems in the past (and protected variables are evil!) | |