Do not assume layout of msghdr and iovec structure
ClosedPublic
Actions

Authored by chinmoyr on Mar 4 2018, 7:27 AM.

Details

Reviewers

dfaure
awilcox

Commits

R241:2a2a8a0fe5ab: Do not assume layout of msghdr and iovec structure

Summary

Class FDMessageHeader assumes the layout of msghdr and iovec structure in its constructor. This assumption is wrong
because as per POSIX standards both may contain more members than usual. This patch fixes the issue.

BUG: 391367

Diff Detail

Repository

R241 KIO

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

chinmoyr created this revision.Mar 4 2018, 7:27 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptMar 4 2018, 7:27 AM

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

chinmoyr requested review of this revision.Mar 4 2018, 7:27 AM

I can confirm that this patch does fix the build on musl. Thank you!

awilcox accepted this revision.Mar 4 2018, 8:12 AM

This revision is now accepted and ready to land.Mar 4 2018, 8:12 AM

In D11011#217980, @awilcox wrote:

I can confirm that this patch does fix the build on musl. Thank you!

I will push this after David's review. I hope it's not a problem?

That's fine with me.

dfaure added inline comments.Mar 4 2018, 9:27 AM

src/ioslaves/file/sharefd_p.h
85	Looks good, it's just a bit inconsistent that iov_base points to io_buf (without &) and msg_control points to &cmsg_buf (with &), both members being char [N]. It turns out that both work, but why not use the same syntax both times?

used &

Thanks, this is good to go in. In fact I'll put it in 5.44 since it fixes a compilation error, once you push it to master (please do today).

Closed by commit R241:2a2a8a0fe5ab: Do not assume layout of msghdr and iovec structure (authored by chinmoyr). · Explain WhyMar 4 2018, 10:57 AM

This revision was automatically updated to reflect the committed changes.

chinmoyr mentioned this in D6709: Add support for sharing file descriptor between KIO slave and KAuth helper.Mar 8 2018, 3:52 PM

Revision Contents
Changeset List

			Path	Packages
M			src/ioslaves/file/sharefd_p.h (11 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	28551	d76a77b		Mar 4 2018, 7:27 AM	★	★
Diff 2	28573	d76a77b	used &	Mar 4 2018, 10:37 AM	★	★
Diff 3	28576	37868c2	R241:2a2a8a0fe5ab882482784c90b217770266b460f4	Mar 4 2018, 10:56 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
e436a18023a6	da6b54ae2804	d76a77b4da69	Chinmoy Ranjan Pradhan	Do not assume layout of msghdr and iovec structure (Show More…)	Mar 4 2018, 7:13 AM

Diff 28576

View Options

src/ioslaves/file/sharefd_p.h