Differential D10962

[Fonts KCM] Make font dialog modal
ClosedPublic
Actions

Authored by broulik on Mar 2 2018, 8:57 AM.

Details

Reviewers
hein
davidedmundson
Group Reviewers
Plasma
Commits
R119:c736f2e8a98c: [Fonts KCM] Make font dialog modal
Summary

This makes it consistent with the "Adjust all fonts" dialog and ensures the dialog doesn't accidentally get hidden behind the KCM

Test Plan

Dialog is modal now, ie. stays in front and dims System Settings but I can still interact with the KCM since it doesn't exec

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 2 2018, 8:57 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 2 2018, 8:57 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Mar 2 2018, 8:57 AM
davidedmundson accepted this revision.Mar 6 2018, 11:34 AM
This revision is now accepted and ready to land.Mar 6 2018, 11:34 AM
Closed by commit R119:c736f2e8a98c: [Fonts KCM] Make font dialog modal (authored by broulik). · Explain WhyMar 6 2018, 1:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 28829

View Options

kcms/fonts/package/contents/ui/main.qml

Loading...