Differential D10942

[kcmkwin/kwindecoration] Properly render shadows with big tiles
ClosedPublic
Actions

Authored by zzag on Mar 1 2018, 2:15 PM.

Details

Reviewers
graesslin
Group Reviewers
KWin
Commits
R108:d50f28033abd: [kcmkwin/kwindecoration] Properly render shadows with big tiles
Summary

Decoration KCM module doesn't render properly shadows with big tiles.
This change tries to address that problem by clipping overlaps, similar
to the OpenGL backend.

Before

After

Test Plan

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Mar 1 2018, 2:15 PM
Restricted Application added a project: KWin. · View Herald TranscriptMar 1 2018, 2:15 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Mar 1 2018, 2:15 PM
zzag edited the summary of this revision. (Show Details)Mar 1 2018, 2:17 PM
zzag edited the summary of this revision. (Show Details)Mar 1 2018, 2:30 PM
zzag updated this revision to Diff 28351.Mar 1 2018, 7:05 PM

delete formatting changes

zzag updated this revision to Diff 28638.Mar 4 2018, 9:06 PM

use ">=" instead of ">" when checking for shadow tile overlaps

abetts added a subscriber: abetts.Mar 5 2018, 12:48 AM

Is there a way that because the shadows are bigger, that the list items can accommodate for that extra space? That way the shadows of one don't overlap on the next list item?

zzag added a comment.Mar 5 2018, 1:19 PM
In D10942#218625, @abetts wrote:

Is there a way that because the shadows are bigger, that the list items can accommodate for that extra space? That way the shadows of one don't overlap on the next list item?

It's a little bit tricky... How it supposed to look when there are decorations with big shadows and small shadows? Also, I think this is out of scope of this patch. :)

abetts added a comment.Mar 5 2018, 3:08 PM
In D10942#219068, @zzag wrote:
In D10942#218625, @abetts wrote:

Is there a way that because the shadows are bigger, that the list items can accommodate for that extra space? That way the shadows of one don't overlap on the next list item?

It's a little bit tricky... How it supposed to look when there are decorations with big shadows and small shadows? Also, I think this is out of scope of this patch. :)

Maybe I will propose that in a different patch to address that.

Thanks

graesslin accepted this revision.Mar 5 2018, 5:54 PM
This revision is now accepted and ready to land.Mar 5 2018, 5:54 PM
zzag updated this revision to Diff 34589.May 21 2018, 4:34 PM

Rebase

zzag retitled this revision from [kcmkwin/kwindecoration] render properly shadows with big tiles to [kcmkwin/kwindecoration] Properly render shadows with big tiles.May 21 2018, 4:34 PM
Closed by commit R108:d50f28033abd: [kcmkwin/kwindecoration] Properly render shadows with big tiles (authored by zzag). · Explain WhyJun 7 2018, 9:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35743

View Options

kcmkwin/kwindecoration/declarative-plugin/previewitem.cpp

Loading...