Differential D10925

Wrap at end of selector instead of in the middle
Needs ReviewPublic
Actions

Authored by Zren on Feb 28 2018, 6:54 PM.

Details

Reviewers

abetts

Group Reviewers

Breeze

Summary

Noticed this when scanning the code for D9773.

If you use a formatting tool and it formats the code like this then ignore this diff.

Test Plan

Didn't test it, just double checked the whitespace.

Diff Detail

Repository

R98 Breeze for Gtk

Lint

Lint Skipped

Unit

Unit Tests Skipped

Zren created this revision.Feb 28 2018, 6:54 PM

Restricted Application added a project: Plasma. · View Herald TranscriptFeb 28 2018, 6:54 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Zren requested review of this revision.Feb 28 2018, 6:54 PM

Didn't test it, just double checked the whitespace.

Why not?

In D10925#219849, @davidedmundson wrote:

Didn't test it, just double checked the whitespace.

Why not?

Lazyness mostly. However on KDE Neon, I'd only be able to test GTK 3.18 anyways by modifying /usr/share/themes/Breeze/gtk-3.18/gtk.css and /usr/share/themes/Breeze-Dark/gtk-3.18/gtk.css. Haven't modified a gtk theme before so haven't really setup a dev/test env for it.

To test for a whitespace change, I'd probably just minify the before and after then diff them to make sure they're the same, but that's overkill for a 16 LOC change.

Revision Contents
Changeset List

			Path	Packages
M			Breeze-dark-gtk/gtk-3.18/gtk.css (16 lines)
M			Breeze-dark-gtk/gtk-3.20/gtk.css (16 lines)
M			Breeze-gtk/gtk-3.18/gtk.css (16 lines)
M			Breeze-gtk/gtk-3.20/gtk.css (16 lines)