Apply coding style to whole project
ClosedPublic

Authored by nicolasfella on Feb 28 2018, 12:46 AM.

Details

Summary

Sorry for the huge diff, but all I did was applying Android Studio's 'Reformat Code' to all files. If everyone does that before submitting a patch we can keep it clean easily.

Test Plan

Compiles

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella requested review of this revision.Feb 28 2018, 12:46 AM
nicolasfella created this revision.

This brings up a good question that I have been meaning to ask for awhile: Are the coding guidelines for this project (KDE Connect) published anywhere?

Asking everyone to run Android Studio's code formatter is probably a good idea, but relies on everyone using the same settings... And getting developers to agree on code style is harder than herding cats :)

At a minimum, the C++ on the Desktop side and the Android on the mobile side are sometimes different. Of course, other than communicating with each other, they are fairly independent, so maybe having their code styles be different is not a big deal.

I think there is a general consensus about C++/Qt coding style in KDE, but I'm not aware of any for Java/Android code. I'm using default settings in Android Studio.

mtijink added a subscriber: mtijink.Mar 3 2018, 2:06 PM

I didn't read through all this, but it seems fine and still works.

I think quickly applying this (and your other related diffs) is best, because it *will* be causing some merge conflicts for the other outstanding diffs.

I didn't read through all this, but it seems fine and still works.

I didn't expect you to :D

So, can I consider this accepted?

mtijink accepted this revision.Mar 3 2018, 3:04 PM

Yes (I forgot to tick the button ๐Ÿ˜…)

This revision is now accepted and ready to land.Mar 3 2018, 3:04 PM
This revision was automatically updated to reflect the committed changes.