templates/cpp-plasmoid/src/package/metadata.desktop
88	I'm not sure, if a 3rd party makes a plasmoid they would call it otherwise. Are we assuming these templates are only for KDE?
templates/qml-plasmoid-with-qml-extension/plugin/%{APPNAMELC}plugin.cpp
33	Isn't his a rather clunky dependency there? I like templates as easy and plain as possible...

templates/cpp-plasmoid/src/package/metadata.desktop
88	Ideally the kapptemplate system would have support for an organization domain parameter which then could be used here (on my notes for some kapptemplatev2). For now this brush-over is proposed with KDE community contributors in mind, to help them getting applets properly prepared e.g. with integration into KDE translations right from the begin. Any 3rd-party which wants to keep their plasmoid 3rd-party would need to adapt the org namespace as desired, which I would expect them to do anyway if they are proud of their org.
templates/qml-plasmoid-with-qml-extension/plugin/%{APPNAMELC}plugin.cpp
33	Yes, not completly sure about this one. But having seen people not getting translation setup correctly, it felt better to add the include and ki18n linking from the start, as removing those lines is easier then adding them correctly. So I would make an exception here for ki18n. But maintainers call, just proposing.

good to go, modulo that possible little code comment more

templates/cpp-plasmoid/src/package/metadata.desktop
88	maybe add a # comment on top of that line staing this?
templates/qml-plasmoid-with-qml-extension/plugin/%{APPNAMELC}plugin.cpp
33	yeah, i agree that i18n is kinda "special" and can make sense to be kept

This revision is now accepted and ready to land.May 21 2018, 11:34 AM

add comment about the need to adapt org.kde.plasma namespace

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			templates/cpp-plasmoid/CMakeLists.txt (10 lines)
M			templates/cpp-plasmoid/Messages.sh (3 lines)
M			templates/cpp-plasmoid/README (17 lines)
M			templates/cpp-plasmoid/src/CMakeLists.txt (5 lines)
M			templates/cpp-plasmoid/src/package/metadata.desktop (3 lines)
M			templates/plasma-wallpaper-with-qml-extension/CMakeLists.txt (1 line)
M			templates/plasma-wallpaper-with-qml-extension/README (17 lines)
M			templates/plasma-wallpaper/CMakeLists.txt (3 lines)
M			templates/plasma-wallpaper/README (17 lines)
M			templates/plasma-wallpaper/package/contents/ui/main.qml (3 lines)
M			templates/qml-plasmoid-with-qml-extension/CMakeLists.txt (8 lines)
M			templates/qml-plasmoid-with-qml-extension/Messages.sh (2 lines)
M			templates/qml-plasmoid-with-qml-extension/README (17 lines)
M			templates/qml-plasmoid-with-qml-extension/package/metadata.desktop (3 lines)
M			templates/qml-plasmoid-with-qml-extension/plugin/%{APPNAMELC}plugin.cpp (5 lines)
M			templates/qml-plasmoid-with-qml-extension/plugin/CMakeLists.txt (3 lines)
M			templates/qml-plasmoid/CMakeLists.txt (5 lines)
M			templates/qml-plasmoid/Messages.sh (2 lines)
M			templates/qml-plasmoid/README (17 lines)
M			templates/qml-plasmoid/package/metadata.desktop (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	28085	3c4f3ed		Feb 26 2018, 6:12 AM	★	★
Diff 2	34574	330ce32	add comment about the need to adapt org.kde.plasma namespace	May 21 2018, 12:03 PM	★	★
Diff 3	34575	330ce32	R242:98e64e01a611cb0e52c15470b06fa81780905b7d	May 21 2018, 12:08 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
df4165fc8d5a	80f6a2eb64ba	330ce3207f8b	Friedrich W. H. Kossebau	Templates: consistent naming, fix translation catalog names & more (Show More…)	Feb 26 2018, 6:11 AM