Differential D10809

autotests: Refactor fileindexerconfigtest
ClosedPublic
Actions

Authored by michaelh on Feb 24 2018, 8:10 PM.

Details

Reviewers
ngraham
Group Reviewers
Baloo
Frameworks
Commits
R293:5bacac6b7f03: autotests: Refactor fileindexerconfigtest
Summary

Make use of QTest data

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
michaelh created this revision.Feb 24 2018, 8:10 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 24 2018, 8:10 PM
michaelh requested review of this revision.Feb 24 2018, 8:10 PM
michaelh updated this revision to Diff 29472.Mar 14 2018, 9:16 AM
  • Keep closer to original
  • Check directory existence
broulik added a subscriber: broulik.Mar 14 2018, 10:53 AM

lgtm but not really an expert in QTemporaryFile

ngraham accepted this revision.Mar 15 2018, 2:36 AM

Seems sane. Code looks acceptable and the tests pass.

This revision is now accepted and ready to land.Mar 15 2018, 2:36 AM
Closed by commit R293:5bacac6b7f03: autotests: Refactor fileindexerconfigtest (authored by michaelh). · Explain WhyMar 15 2018, 5:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 29618

View Options

autotests/unit/file/fileindexerconfigtest.h

Loading...
View Options

autotests/unit/file/fileindexerconfigtest.cpp

Loading...